Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update doc on 0.19.0 #2484

Closed
Fantaztig opened this issue Oct 23, 2019 · 2 comments
Closed

Update doc on 0.19.0 #2484

Fantaztig opened this issue Oct 23, 2019 · 2 comments
Assignees

Comments

@Fantaztig
Copy link

Fantaztig commented Oct 23, 2019

Section/Content To Improve
Changelog 0.19.0

Suggested Improvement
We are using axios in our application and had the problem that the no_proxy environment variable was not correctly used.
I saw this was fixed in 0.19.0-beta.1 back in august 2018.
Howevern in the change and release notes of 0.19.0 there was no mention of those fixes, they were still only mentioned for the beta release.
Therefore it was hard for me to decide whether I should use 0.19.0 or the beta version.

Relevant File(s): Changelog

@yasuf
Copy link
Collaborator

yasuf commented Oct 25, 2019

do you know the PR where that was fixed? was it this one https://github.com/axios/axios/pull/1693/files ? What message do you think it's appropriate?

@Fantaztig
Copy link
Author

Yes it was #1693, the message is understandable as well.
It was just unclear to me wether the current version 0.19.0 includes this PR or not as the PR is not listed in the changelog for version 0.19.0.
The PR is however included in the changelog for 0.19.0-beta.1, but the beta was released Aug 9, 2018, while 0.19.0 was released May 30, 2019.
Therefore I would expect all PRs from 0.19.0-beta.1 to be included in 0.19.0 as well, which I think should reflect in the changelog.

@yasuf yasuf self-assigned this Nov 4, 2019
yasuf added a commit to yasuf/axios that referenced this issue Nov 4, 2019
@yasuf yasuf closed this as completed Nov 4, 2019
@axios axios locked and limited conversation to collaborators May 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants