Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I don’t think this thing is necessary, I should delete it. #2458

Merged
merged 5 commits into from Dec 25, 2019

Conversation

notbucai
Copy link
Contributor

@notbucai notbucai commented Oct 10, 2019

If this place is false, it will report an error, so you should delete the useless code.

@notbucai notbucai closed this Oct 22, 2019
@notbucai
Copy link
Contributor Author

notbucai commented Nov 9, 2019

I still think this is not necessary because he has already made a judgment on line 27.

config.headers = config.headers || {};

@notbucai notbucai reopened this Nov 9, 2019
@notbucai notbucai changed the title If this place is false, it will report an error, so you should delete… I don’t think this thing is necessary, I should delete it. Nov 9, 2019
@yasuf yasuf merged commit ee47120 into axios:master Dec 25, 2019
@axios axios locked and limited conversation to collaborators May 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants