Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for custom attributes #2438

Closed
songyuanlu opened this issue Sep 26, 2019 · 7 comments
Closed

Support for custom attributes #2438

songyuanlu opened this issue Sep 26, 2019 · 7 comments

Comments

@songyuanlu
Copy link

Support for custom attributes

I want to set a custom property.
  {
showLoading: true,
isFilter: false
}
Use these attributes to do public interception.
If it shows loading
Whether to intercept the exception

@xsteadybcgo
Copy link

xsteadybcgo commented Sep 30, 2019

in v0.18.0, it works well , but in v0.19.0 fail, i search the source code and git commit history. find that this repo had a refactor about deepMerge and ony these configs are supported.
I wonder if it's a bug or limit ?
image

related discussion #2203

@songyuanlu
Copy link
Author

I think it's a limit.
Because in business, I can't set custom properties anymore.
So many things can't be done.
I'll try to see if v0.18.0 is OK.

@Drider
Copy link

Drider commented Oct 2, 2019

@songyuanlu I think here #2295 you can find additional information.

@xiaoyouyu
Copy link

the axios.get can't set custom properties in v0.18.0

1570042146(1)
1570042146

@songyuanlu
Copy link
Author

@songyuanlu I think here #2295 you can find additional information.

Well
It helps me.

@yasuf
Copy link
Collaborator

yasuf commented Oct 29, 2019

So I just tested this on master and it has been fixed already, it's just that the dist hasn't been updated, so we'll probably just have to update it and bump the version on NPM.
See #2502

@emilyemorehouse
Copy link
Member

This has been fixed in the recent 0.19.1 release

@axios axios locked and limited conversation to collaborators May 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants