Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Response doesn't contain config.meta since 0.19.0 #2252

Closed
ivankdev opened this issue Jun 28, 2019 · 3 comments
Closed

Response doesn't contain config.meta since 0.19.0 #2252

ivankdev opened this issue Jun 28, 2019 · 3 comments

Comments

@ivankdev
Copy link

ivankdev commented Jun 28, 2019

On version 0.18.0 could be use meta parameter like this

const api = axios.create({....})
api.get('/someroute', {meta: {somemeta: true}})

It was available inside of config on response. But since update on 0.19.0 I've stopped watching meta there. No found any information about this in changelog also. It may be not a bug, but can you explain this missing, please.

To Reproduce

var axios = require("axios") // with  0.18.0 and 0.19.0 responses are different
axios.get('https://www.google.com/', {meta: {somemeta: true}}).then(res => {console.log(res)})

Expected behavior
Expect to see meta object inside of res.config

Environment:

  • Axios Version 0.19.0
  • OS: OS 12.2
  • Additional Library Versions: React 16.8.6, React Native 0.59.9
@jphilipstevens
Copy link
Collaborator

jphilipstevens commented Jun 28, 2019

I believe that there was a breaking change. The fix should be in this PR: #2207

for now downgrade to 0.18 is what we were recommended

@93hsc
Copy link

93hsc commented Jul 11, 2019

mark

@chinesedfan
Copy link
Collaborator

#2207 has been merged and 0.19.1 includes it.

@axios axios locked and limited conversation to collaborators May 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants