Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid URL is throwing an error that is circular JSON #1913

Closed
hineshamin opened this issue Dec 6, 2018 · 1 comment
Closed

Invalid URL is throwing an error that is circular JSON #1913

hineshamin opened this issue Dec 6, 2018 · 1 comment

Comments

@hineshamin
Copy link

Summary

I am working through an issue with making an axios call to an invalid URL. A simple mistake I made in my URL is that when importing I was accidentally importing an object as the URL and so the request URL looked something like this "[object]/blog" which is an invalid URL. The error that was thrown by axios had circular JSON and so I was getting a very unhelpful error thrown by express that it could not parse circular JSON. Axios should throw errors that are natively able to be stringified from JSON so that I can stringify the error. PR #1625 looked to have fixed this issue however it looks like the same issue is occurring that it was looking to fix.

Context

  • axios version: v0.18.0
  • Environment: node v10.6.0, macOS v10.14.1
@hineshamin
Copy link
Author

Closing this issue as I saw that this was fixed in v0.19.0 and I am using v0.18.0

@axios axios locked and limited conversation to collaborators May 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant