Basic auth fails with non latin characters in username or password

[CameronFraser]

Summary

The usage of btoa for basic auth prevents usage of non latin characters
Not really a big deal as you do not have to use the basic auth and can encode it yourself but thought I'd bring it up at least as passwords are becoming more unique.

axios/lib/adapters/xhr.js

Line 42 in 0499a97

requestHeaders.Authorization = 'Basic ' + btoa(username + ':' + password);

To reproduce try using a password with basic auth that has a ҂ symbol in it or by opening up a console and trying to use the btoa function on a string with a ҂ symbol.

[radreamer]

+1

@defdata , you can use next code as a temporary solution:

auth: {
    username,
    password: unescape(encodeURIComponent(password)),
},

[jennynju]

What's the status of this issue currently?
I also encountered this issue when username includes Unicode.

To Reproduce:

axios.post('/sessions', {}, { auth: { username: '中文', password: 'password' } });

[jennynju]

Add unescape can fix my issue:
` var request = new XMLHttpRequest();

// HTTP basic authentication
if (config.auth) {
  var username = config.auth.username || '';
  var password = config.auth.password || '';
  requestHeaders.Authorization = 'Basic ' + btoa(unescape(encodeURIComponent(username + ':' + password)));
}`

[m-ruhl]

I have the same issue..

[dohkoxiaozu]

What's the status of this issue currently?
I also encountered this issue when username includes Unicode.

To Reproduce:

axios.post('/sessions', {}, { auth: { username: '中文', password: 'password' } });

@JustinBeckwith Is there any solution for fixing this problem?

[offtherailz]

Sorry @jasonsaayman if I re-post on this issue.
Solution in #1492 encodes only password, but the failure can be caused both from username and password.
Encoding should be done on both, isn't it?