error: window is undefined in web worker

[darosh]

Summary

After upgrade from 0.16.2 to 0.17.0 I got error window is undefined when running in web worker at line:

axios/lib/adapters/xhr.js

Line 27 in 2c0e318

if (!window.XMLHttpRequest &&

Changing order of conditions typeof window !== 'undefined' and !window.XMLHttpRequest fixes the error.

Context

• axios version: 0.17.0
• Environment: web worker in Chrome

Notes

looking closer ar xhr.js:

• typeof window checks could be probably replaced with typeof XMLHttpRequest and typeof btoa
• There is new XMLHttpRequest() few lines prior !window.XMLHttpRequest check. I would expect, in case !window.XMLHttpRequest is true, new XMLHttpRequest() will throw error before the check and the check is never performed

[darosh]

Duplicated: #1161, Related: #1160

[nickuraltsev]

Fixed via #1160