Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PKCE support #218

Open
poveden opened this issue Oct 6, 2022 · 2 comments
Open

Add PKCE support #218

poveden opened this issue Oct 6, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@poveden
Copy link
Contributor

poveden commented Oct 6, 2022

Summary

Add support for RFC 7636: Proof Key for Code Exchange (PKCE).

Additional Context

PKCE was originally designed to protect the authorization code flow in mobile apps, but its ability to prevent authorization code injection makes it useful for every type of OAuth client, even web apps that use a client secret.

YouTube: OAuth 2.0 Auth Code Injection Attack in Action (thanks @acasella for the link!)
@poveden poveden added the enhancement New feature or request label Oct 6, 2022
@tanettrimas
Copy link

tanettrimas commented Jun 7, 2023 •
edited

Hi!

I am considering implementing support for this. Would this be considered a breaking change given that PKCE is required in OAuth 2.1 or should it just be optional to support OAuth 2.0-requests? :)

@nulltoken
Copy link
Contributor

👋 I don't see this as a breaking change.

@poveden Thoughts?

@tanettrimas tanettrimas mentioned this issue Jun 29, 2023
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nulltoken @poveden @tanettrimas