Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export url::URL #317

Open
webern opened this issue Jan 6, 2021 · 0 comments
Open

Export url::URL #317

webern opened this issue Jan 6, 2021 · 0 comments

Comments

@webern
Copy link
Contributor

webern commented Jan 6, 2021

Should we either export url::Url, e.g. as tough::Url? Or should we eliminate Url from the public interface?

I think best practice is to re-export, but I'm not sure. The reason I realized maybe we should do this is that, while working on something else, I wrote a quite test program with tough and it didn't compile because I typed url = "1" instead of url = "2". I'm sure how annoying it could be in a project to need to align Url's version with tough's use thereof (or how exact that version match needs to be).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant