Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tough: Reduce the Error Type's API Surface Area #300

Open
webern opened this issue Dec 19, 2020 · 0 comments
Open

tough: Reduce the Error Type's API Surface Area #300

webern opened this issue Dec 19, 2020 · 0 comments
Milestone

Comments

@webern
Copy link
Contributor

webern commented Dec 19, 2020

@iliana mentioned in #256

Opaque structs might solve the separate issue of our error variants being particularly purpose-specific, which makes stabilization more difficult.

Good point. The tough Error type is an enum with numerous variants. This presents a large API surface area for the error type which we should reduce significantly before v1.0.0.

Random thought, it seems weird that errors specific to RepositoryEditor would be in the same enum as errors unrelated to the RepositoryEditor, so there may be an opportunity there to use a different type for RepositoryEditor.

But, in general, we definitely need to hide a lot of the minutiae currently exposed by the tough error type in order to avoid frequent breaking changes.

@webern webern added this to the tough-v1.0.0 milestone Dec 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant