Request IDs #2054

82marbag · 2022-12-02T18:00:40Z

Motivation and Context

Implement RFC 24: Request IDs in business logic

Testing

From the example:

This request has this client ID: None and server ID: f864ce5f-c5cd-45b0-b1ec-dde190aa8e8d
This request has this client ID: Some(ClientRequestId { id: "hello" }) and server ID: 6b690212-5f73-48cb-b13c-47c56e1cb792

Checklist

I have updated CHANGELOG.next.toml if I made changes to the smithy-rs codegen or runtime crates
I have updated CHANGELOG.next.toml if I made changes to the AWS SDK, generated SDK code, or SDK runtime crates

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Signed-off-by: Daniele Ahmed <ahmeddan@amazon.de>

github-actions · 2022-12-02T18:16:58Z

A new generated diff is ready to view.

AWS SDK (ignoring whitespace)
No codegen difference in the Server Test
No codegen difference in the Server Test Python

A new doc preview is ready to view.

Signed-off-by: Daniele Ahmed <ahmeddan@amazon.de>

github-actions · 2022-12-03T13:02:04Z

A new generated diff is ready to view.

A new doc preview is ready to view.

rust-runtime/aws-smithy-http-server/src/request/request_id.rs

...time/aws-smithy-http-server/examples/pokemon-service/src/bin/pokemon-service-connect-info.rs

hlbarber · 2022-12-05T10:17:43Z

rust-runtime/aws-smithy-http-server/src/request/request_id.rs

+}
+
+pub struct ClientRequestIdProviderLayer<'a> {
+    possible_headers: &'a [&'a str],


Is there ever a chance where we use less than 'static here?

rust-runtime/aws-smithy-http-server/Cargo.toml

rust-runtime/aws-smithy-http-server/src/request/request_id.rs

hlbarber · 2022-12-06T10:19:03Z

rust-runtime/aws-smithy-http-server/src/request/request_id.rs

+pub struct MissingClientRequestId;
+
+impl ClientRequestId {
+    pub fn new(id: Box<str>) -> Self {


Perhaps lots of From implementations instead of this new - e.g. From<Box<str>>, From<String> and From<Cow<'static, str>>.

What about pub fn new(id: impl Into<&str>) or something along the lines?

Signed-off-by: Daniele Ahmed <ahmeddan@amazon.de>

github-actions · 2022-12-07T10:06:02Z

A new generated diff is ready to view.

A new doc preview is ready to view.

rust-runtime/aws-smithy-http-server/Cargo.toml

...time/aws-smithy-http-server/examples/pokemon-service/src/bin/pokemon-service-connect-info.rs

rust-runtime/aws-smithy-http-server/src/request/request_id.rs

github-actions · 2022-12-07T10:23:50Z

A new generated diff is ready to view.

A new doc preview is ready to view.

Co-authored-by: Luca Palmieri <20745048+LukeMathWalker@users.noreply.github.com>

rust-runtime/aws-smithy-http-server/src/request/request_id.rs

github-actions · 2022-12-07T10:38:14Z

A new generated diff is ready to view.

A new doc preview is ready to view.

Co-authored-by: Luca Palmieri <20745048+LukeMathWalker@users.noreply.github.com>

github-actions · 2022-12-07T11:11:26Z

A new generated diff is ready to view.

A new doc preview is ready to view.

Signed-off-by: Daniele Ahmed <ahmeddan@amazon.de>

github-actions · 2022-12-07T14:54:44Z

A new generated diff is ready to view.

AWS SDK (ignoring whitespace)
No codegen difference in the Server Test
No codegen difference in the Server Test Python

A new doc preview is ready to view.

rust-runtime/aws-smithy-http-server/src/request/request_id.rs

Signed-off-by: Daniele Ahmed <ahmeddan@amazon.de>

github-actions · 2022-12-20T16:08:58Z

A new generated diff is ready to view.

A new doc preview is ready to view.

crisidev · 2022-12-21T11:04:02Z

CI is failing: https://github.com/awslabs/smithy-rs/actions/runs/3742073103/jobs/6352563186#step:3:1011

Signed-off-by: Daniele Ahmed <ahmeddan@amazon.de>

github-actions · 2022-12-21T15:50:53Z

A new generated diff is ready to view.

A new doc preview is ready to view.

...time/aws-smithy-http-server/examples/pokemon-service/src/bin/pokemon-service-connect-info.rs

This reverts commit 19bf72b.

Signed-off-by: Daniele Ahmed <ahmeddan@amazon.de>

github-actions · 2022-12-22T11:51:19Z

A new generated diff is ready to view.

A new doc preview is ready to view.

Signed-off-by: Daniele Ahmed <ahmeddan@amazon.de>

github-actions · 2022-12-22T16:33:22Z

A new generated diff is ready to view.

A new doc preview is ready to view.

github-actions · 2022-12-22T17:12:56Z

A new generated diff is ready to view.

AWS SDK (ignoring whitespace)
No codegen difference in the Server Test
No codegen difference in the Server Test Python

A new doc preview is ready to view.

82marbag added 2 commits December 2, 2022 18:29

Request IDs

ecbaddd

Signed-off-by: Daniele Ahmed <ahmeddan@amazon.de>

Add example

9f35197

Signed-off-by: Daniele Ahmed <ahmeddan@amazon.de>

82marbag requested review from a team as code owners December 2, 2022 18:00

82marbag requested review from david-perez and drganjoo December 2, 2022 18:00

82marbag added 3 commits December 2, 2022 19:01

RFC status: implemented

f058767

Signed-off-by: Daniele Ahmed <ahmeddan@amazon.de>

Clean imports

fabbaa2

Signed-off-by: Daniele Ahmed <ahmeddan@amazon.de>

Use tracing

b65062c

Signed-off-by: Daniele Ahmed <ahmeddan@amazon.de>

Add Default impls

96bb46e

Signed-off-by: Daniele Ahmed <ahmeddan@amazon.de>

hlbarber reviewed Dec 5, 2022

View reviewed changes

hlbarber added server Rust server SDK needs-server-review labels Dec 6, 2022

LukeMathWalker reviewed Dec 6, 2022

View reviewed changes

rust-runtime/aws-smithy-http-server/Cargo.toml Outdated Show resolved Hide resolved

LukeMathWalker reviewed Dec 6, 2022

View reviewed changes

rust-runtime/aws-smithy-http-server/src/request/request_id.rs Show resolved Hide resolved

hlbarber reviewed Dec 6, 2022

View reviewed changes

Address comments

81889b8

Signed-off-by: Daniele Ahmed <ahmeddan@amazon.de>

LukeMathWalker reviewed Dec 7, 2022

View reviewed changes

rust-runtime/aws-smithy-http-server/Cargo.toml Outdated Show resolved Hide resolved

Update rust-runtime/aws-smithy-http-server/Cargo.toml

63959ac

LukeMathWalker reviewed Dec 7, 2022

View reviewed changes

...time/aws-smithy-http-server/examples/pokemon-service/src/bin/pokemon-service-connect-info.rs Outdated Show resolved Hide resolved

LukeMathWalker reviewed Dec 7, 2022

View reviewed changes

rust-runtime/aws-smithy-http-server/src/request/request_id.rs Outdated Show resolved Hide resolved

Update rust-runtime/aws-smithy-http-server/src/request/request_id.rs

cd212e5

Co-authored-by: Luca Palmieri <20745048+LukeMathWalker@users.noreply.github.com>

LukeMathWalker reviewed Dec 7, 2022

View reviewed changes

rust-runtime/aws-smithy-http-server/src/request/request_id.rs Outdated Show resolved Hide resolved

Update rust-runtime/aws-smithy-http-server/src/request/request_id.rs

2dc2112

Co-authored-by: Luca Palmieri <20745048+LukeMathWalker@users.noreply.github.com>

82marbag added 2 commits December 7, 2022 15:41

Merge branch 'main' into requestid

1f83ae9

Use new Option impl for FromParts

355a102

Signed-off-by: Daniele Ahmed <ahmeddan@amazon.de>

LukeMathWalker reviewed Dec 8, 2022

View reviewed changes

rust-runtime/aws-smithy-http-server/src/request/request_id.rs Outdated Show resolved Hide resolved

82marbag added 2 commits December 20, 2022 16:48

Remove ClientRequestId

959114d

Signed-off-by: Daniele Ahmed <ahmeddan@amazon.de>

Fix style

4d5cced

Signed-off-by: Daniele Ahmed <ahmeddan@amazon.de>

LukeMathWalker approved these changes Dec 21, 2022

View reviewed changes

crisidev approved these changes Dec 21, 2022

View reviewed changes

82marbag added 2 commits December 21, 2022 16:26

Feature flag example

19bf72b

Signed-off-by: Daniele Ahmed <ahmeddan@amazon.de>

Fix CI

2a3d881

Signed-off-by: Daniele Ahmed <ahmeddan@amazon.de>

LukeMathWalker reviewed Dec 21, 2022

View reviewed changes

...time/aws-smithy-http-server/examples/pokemon-service/src/bin/pokemon-service-connect-info.rs Outdated Show resolved Hide resolved

Daniele Ahmed and others added 2 commits December 22, 2022 12:35

Revert "Feature flag example"

13dada7

This reverts commit 19bf72b.

Enable request-id flag in example

d58f700

Signed-off-by: Daniele Ahmed <ahmeddan@amazon.de>

Ignore example doc

c25364e

Signed-off-by: Daniele Ahmed <ahmeddan@amazon.de>

82marbag enabled auto-merge (squash) December 22, 2022 16:24

Merge branch 'main' into requestid

e5dcf6d

82marbag merged commit 87e45f6 into main Dec 22, 2022

82marbag deleted the requestid branch December 22, 2022 17:31

82marbag mentioned this pull request Jan 10, 2023

Update changelog with request ID #2193

Merged

Velfi removed the needs-server-review label Jun 5, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Request IDs #2054

Request IDs #2054

82marbag commented Dec 2, 2022

github-actions bot commented Dec 2, 2022

github-actions bot commented Dec 3, 2022

hlbarber Dec 5, 2022

hlbarber Dec 6, 2022 •

edited

crisidev Dec 21, 2022

github-actions bot commented Dec 7, 2022

github-actions bot commented Dec 7, 2022

github-actions bot commented Dec 7, 2022

github-actions bot commented Dec 7, 2022

github-actions bot commented Dec 7, 2022

github-actions bot commented Dec 20, 2022

crisidev commented Dec 21, 2022

github-actions bot commented Dec 21, 2022

github-actions bot commented Dec 22, 2022

github-actions bot commented Dec 22, 2022

github-actions bot commented Dec 22, 2022

Request IDs #2054

Request IDs #2054

Conversation

82marbag commented Dec 2, 2022

Motivation and Context

Testing

Checklist

github-actions bot commented Dec 2, 2022

github-actions bot commented Dec 3, 2022

hlbarber Dec 5, 2022

Choose a reason for hiding this comment

hlbarber Dec 6, 2022 • edited

Choose a reason for hiding this comment

crisidev Dec 21, 2022

Choose a reason for hiding this comment

github-actions bot commented Dec 7, 2022

github-actions bot commented Dec 7, 2022

github-actions bot commented Dec 7, 2022

github-actions bot commented Dec 7, 2022

github-actions bot commented Dec 7, 2022

github-actions bot commented Dec 20, 2022

crisidev commented Dec 21, 2022

github-actions bot commented Dec 21, 2022

github-actions bot commented Dec 22, 2022

github-actions bot commented Dec 22, 2022

github-actions bot commented Dec 22, 2022

hlbarber Dec 6, 2022 •

edited