Rename aws_types::Config to aws_types::SdkConfig`

[Velfi]

Tell us about your request

Rename aws_types::Config to aws_types::SdkConfig

Tell us about the problem you're trying to solve.

Users struggle to understand the difference between a Config struct from a service SDK and a Config struct from aws_types. Renaming the type would make users less likely to think the Config structs are interchangeable.

Are you currently working around this issue?

It's possible to alias the type but this doesn't help users that don't already know the difference

Additional context

No response

[benesch]

Yes, please! This was one of my primary sources of confusion when learning the SDK.

One note: SharedConfig is easy to misinterpret. The correct interpretation is “configuration common to all SDK clients” (right?) but it’s reminiscent of a “global shared configuration object” like an Arc.

CommonConfig strikes me as maybe a bit clearer?

I definitely retract my suggestion if there’s prior art in other SDKs that use the “Shared” terminology, though.

[Velfi]

This is now in PR

[Velfi]

The PR has been merged and this feature is now pending release. Per a poll we held on the internal AWS Slack, we decided on SdkConfig over SharedConfig. Chief among the reasons why we made that choice is that we already use the word Shared to prefix names of types that are wrapped in an Arc.

[benesch]

The PR has been merged and this feature is now pending release. Per a poll we held on the internal AWS Slack, we decided on SdkConfig over SharedConfig. Chief among the reasons why we made that choice is that we already use the word Shared to prefix names of types that are wrapped in an Arc.

SdkConfig sounds great to me, too!

[jdisanti]

This was released with v0.9.0.

[github-actions]

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.