Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Telemetry API #563

Merged
merged 4 commits into from Nov 14, 2022
Merged

Conversation

RafalSumislawski
Copy link
Contributor

@RafalSumislawski RafalSumislawski commented Nov 10, 2022

Description of changes:

This PR adds support for the new Telemetry API in parallel to the already supported Logging API.

By submitting this pull request

  • I confirm that my contribution is made under the terms of the Apache 2.0 license.
  • I confirm that I've made a best effort attempt to update all relevant documentation.

@calavera
Copy link
Contributor

are there any docs or blog posts about this new API? I have not seen that announcement yet

@calavera
Copy link
Contributor

@RafalSumislawski it'd be awesome if you added an example on how to use this new API in the examples directory: https://github.com/awslabs/aws-lambda-rust-runtime/tree/main/examples

@RafalSumislawski
Copy link
Contributor Author

I will.

@RafalSumislawski
Copy link
Contributor Author

@calavera
Copy link
Contributor

It has been announced an hour ago ;)

that was quick, nice job!

Copy link
Contributor

@calavera calavera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you fix the clippy issues?

Copy link
Contributor

@calavera calavera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the contribution, the code looks solid. We should be able to merge it as soon as the CI passes and we have some docs in the README.md for the extension and examples in the examples directory 🙌

lambda-extension/src/extension.rs Outdated Show resolved Hide resolved
@bnusunny
Copy link
Contributor

@RafalSumislawski This looks nice. Thanks for your contribution.

@RafalSumislawski
Copy link
Contributor Author

I did all the requested changes. No more clippy warnings. The docs and examples are updated. Thanks for the patience ;)

Copy link
Contributor

@calavera calavera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is awesome, thanks for contributing to the project @RafalSumislawski !

@calavera calavera merged commit 0839125 into awslabs:main Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants