Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

codegen: remove "V2" suffix from endpoint resolution codegen #476

Open
lucix-aws opened this issue Nov 27, 2023 · 0 comments
Open

codegen: remove "V2" suffix from endpoint resolution codegen #476

lucix-aws opened this issue Nov 27, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@lucix-aws
Copy link
Contributor

We implemented codegen for @endpointRuleSet to generate EndpointResolverV2 because EndpointResolver as a name was already taken downstream by the go v2 SDK's existing endpoint resolver.

We need to separate the concerns of the SDK from smithy-go in general, the smithy-go codegen should be rebranded to generate as EndpointResolver and the SDK will have to customize around it somehow.
@lucix-aws lucix-aws added the enhancement New feature or request label Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lucix-aws