[issues-391] Fix document typecheck in encoding for nested types #394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This resolves github issue 391 where encoding of document types is not checking to see if nested types are explicitly marked for no serialization or deserialization. In order to to check for every layer of nesting, I moved the noserde check to the recursive layer from the original top-level function. This mimics how it correctly works in decoding
isaiahvita
commented
Oct 21, 2022
document/json/encoder.go
Outdated
|
|
||
| func (e *Encoder) unsupportedType(v interface{}) error { | ||
| if document.IsNoSerde(v) { | ||
| return &document.InvalidUnmarshalError{Type: reflect.TypeOf(v)} |
There was a problem hiding this comment.
@skmcgrail is this backwards incompatible? should i be performing the same error behavior as L24?
skmcgrail
reviewed
Oct 21, 2022
Comment on lines
-23
to
-26
| if document.IsNoSerde(v) { | ||
| return nil, fmt.Errorf("unsupported type: %v", v) | ||
| } | ||
|
|
There was a problem hiding this comment.
Wondering if this check should stay? Otherwise I think lines 71-78 in the encode function could still serialize the zero value of a generated Smithy type as an empty object which would be weird?
There was a problem hiding this comment.
in my previous implementation, the document.IsNoSerde func was still being called, i had just wrapped it in another function isUnsupported. however, in my latest commit, I replaced that to more closely mimic decode which actually directly calls document.IsNoSerde when decoding a struct
skmcgrail
approved these changes
Oct 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves github issue 391 where encoding of document types is not checking to see if nested types are explicitly marked for no serialization or deserialization. In order to to check for every layer of nesting, I moved the noserde check to the recursive layer from the original top-level function. This mimics how it correctly works in decoding
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.