Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: find way to catch build issues related to cargo publish at PR creation time #2064

Open
WesleyRosenblum opened this issue Dec 8, 2023 · 0 comments
Labels
ci Tasks related to ci priority/low Rank 4 size/small

Comments

@WesleyRosenblum
Copy link
Contributor

Problem:

#2009 added additional checks to the CI that ensure that the cargo package command succeeds on every PR. This was intended to catch build issues that a normal cargo build does not catch prior to publishing the crates. cargo package works by pulling dependencies (including those in the workspace) directly from crates.io, meaning that when changes are made in one crate that depend on another crate, the cargo package command may fail.

Solution:

TBD. If there were a way to run cargo package using local workspace versions, that could potentially work.

Requirements / Acceptance Criteria:

A pull request that contains changes that will prevent cargo publish from succeeding will fail CI; otherwise the CI must pass

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Tasks related to ci priority/low Rank 4 size/small
Projects
None yet
Development

No branches or pull requests

1 participant