Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in Install documentation with Helm TF provider #2345

Closed
photosojourn opened this issue Aug 23, 2022 · 4 comments
Closed

Error in Install documentation with Helm TF provider #2345

photosojourn opened this issue Aug 23, 2022 · 4 comments
Labels
lifecycle/closed lifecycle/stale question Further information is requested

Comments

@photosojourn
Copy link

Hey,

During testing, I found an error in the examples for Getting Started with Terraform - Install Karpenter Helm Chart. Due to changes released in Kubectl 1.24 which where rolled into Helm the TF provider needs to the pinned to version .2.5.1 as documented here.

Given EKS 1.23 is out the whole section prob needs a refresh. :)

Thanks!

@photosojourn photosojourn changed the title Error in Install documentation with Hellm TF provider Error in Install documentation with Helm TF provider Aug 23, 2022
@FernandoMiguel
Copy link
Contributor

but those docs already use v1beta1, not v1alpha1
api_version = "client.authentication.k8s.io/v1beta1"

@bwagner5
Copy link
Contributor

Is the only part missing the version pin?

    helm = {
      source  = "hashicorp/helm"
      version = "~> 2.5"
    }

I thought that ~> 2.5 would allow 2.5.1 , but I might be mistaken.

From Terraform docs:

[~>](https://www.terraform.io/language/expressions/version-constraints#-3): Allows only the rightmost version component to increment. For example, to allow new patch releases within a specific minor release, use the full version number: ~> 1.0.4 will allow installation of 1.0.5 and 1.0.10 but not 1.1.0. This is usually called the pessimistic constraint operator.

This reads like ~> 2.5 only allows it to install 2.6 and not patches... which makes no sense to me...

Maybe we should use >= 2.5.1, < 3.0.0 ?

@bwagner5 bwagner5 added the question Further information is requested label Aug 23, 2022
@FernandoMiguel
Copy link
Contributor

I thought that ~> 2.5 would allow 2.5.1 , but I might be mistaken.

from my experience, it should. but very easy to test

@github-actions
Copy link
Contributor

Labeled for closure due to inactivity in 10 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/closed lifecycle/stale question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants