Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(go): replace uses of CanConvert to Type.AssignableTo #3373

Merged
merged 2 commits into from Feb 9, 2022
Merged

fix(go): replace uses of CanConvert to Type.AssignableTo #3373

merged 2 commits into from Feb 9, 2022

Conversation

RomainMuller
Copy link
Contributor

@RomainMuller RomainMuller commented Feb 9, 2022 •
edited

This preserves compatibility with Go 1.16, as CanConvert was introduced
in go 1.17 only.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@RomainMuller
fix(go): replace uses of CanConvert to Type.AssignableTo
e536231 
This preserves compatibility with Go 1.16, as CanConvert was introduced
in go 1.17 only.
@RomainMuller RomainMuller requested a review from a team February 9, 2022 10:37
@RomainMuller RomainMuller self-assigned this Feb 9, 2022
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Feb 9, 2022
@RomainMuller RomainMuller merged commit ae4ea62 into main Feb 9, 2022
@RomainMuller RomainMuller deleted the rmuller/go-canconvert branch February 9, 2022 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@RomainMuller RomainMuller

Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@RomainMuller