Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go Pacmak OOM Crash and Performance #3361

Closed
MrArnoldPalmer opened this issue Jan 31, 2022 · 3 comments
Closed

Go Pacmak OOM Crash and Performance #3361

MrArnoldPalmer opened this issue Jan 31, 2022 · 3 comments
Assignees

Comments

@MrArnoldPalmer
Copy link
Contributor

MrArnoldPalmer commented Jan 31, 2022

We have received reports that jsii-pacmak can run out of memory causing crashes on large packages while doing Go code generation. Additionally we have seen the time it takes to generate go packages is significantly higher than other languages.

This is somewhat expected as the Go code generation is built differently than the other languages since it is the only generator that was built with submodule support in mind. There may be a number of easy optimizations to reduce memory usage and overall runtime via memoization during both first pass AST generation and second pass output.

@ansgarm
Copy link
Contributor

ansgarm commented Feb 1, 2022

This is resolved by #3362, isn't it?

@MrArnoldPalmer
Copy link
Contributor Author

correct, should be improved in the next release.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2022

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

3 participants