Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(go): Use type registry to find the correct target type for JSII Proxy #3354

Merged
merged 2 commits into from Feb 3, 2022

Conversation

arnogeurts-sqills
Copy link
Contributor

With this PR, the type that is instantiated as JSII Proxy is looked up from the type registry using the TypeFQDN in the ref. If that type is registered in the type registry AND that type is assignable to the targeted value type, than that type is used to instantiate the JSII proxy.

Fixes #3353 and relates to #2819.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mergify
Copy link
Contributor

mergify bot commented Jan 31, 2022

The title of this Pull Request does not conform with [Conventional Commits] guidelines. It will need to be adjusted before the PR can be merged.
[Conventional Commits]: https://www.conventionalcommits.org

@arnogeurts-sqills arnogeurts-sqills changed the title Use type registry to find the correct target type for JSII Proxy feat(go): Use type registry to find the correct target type for JSII Proxy Jan 31, 2022
Copy link
Contributor

@RomainMuller RomainMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice - thank you!

I only have a very minor comment here, and we're ready to ship.

@RomainMuller
Copy link
Contributor

@all-contributors add @arnogeurts-sqills for bug, code

@allcontributors
Copy link
Contributor

@RomainMuller

I've put up a pull request to add @arnogeurts-sqills! 🎉

…ersions.go

Co-authored-by: Romain Marcadier <romain.muller@telecomnancy.net>
@mergify
Copy link
Contributor

mergify bot commented Feb 2, 2022

The title of this Pull Request does not conform with [Conventional Commits] guidelines. It will need to be adjusted before the PR can be merged.
[Conventional Commits]: https://www.conventionalcommits.org

@arnogeurts-sqills
Copy link
Contributor Author

@RomainMuller do you need/expect anything else from me regarding this PR, or can it be merged?

@RomainMuller
Copy link
Contributor

@RomainMuller do you need/expect anything else from me regarding this PR, or can it be merged?

It'll be merged! I had actually hoped automation would merge it overnight!

@RomainMuller RomainMuller merged commit 75d94ef into aws:main Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Go runtime does not allow type assertions to raw CFN resource types
2 participants