Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(jsii): submodule READMEs don't have literate examples #3347

Merged
merged 4 commits into from Jan 24, 2022

Conversation

rix0rrr
Copy link
Contributor

@rix0rrr rix0rrr commented Jan 21, 2022

The code literally was not there to extract literate examples for
submodule READMEs.

Fixes aws/aws-cdk#18589.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

The code literally was not there to extract literate examples for
submodule READMEs.

Fixes aws/aws-cdk#18589.
@rix0rrr rix0rrr requested a review from a team January 21, 2022 16:15
@rix0rrr rix0rrr self-assigned this Jan 21, 2022
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jan 21, 2022
Copy link
Contributor

@kaizencc kaizencc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@mergify
Copy link
Contributor

mergify bot commented Jan 24, 2022

The title of this Pull Request does not conform with [Conventional Commits] guidelines. It will need to be adjusted before the PR can be merged.
[Conventional Commits]: https://www.conventionalcommits.org

@mergify
Copy link
Contributor

mergify bot commented Jan 24, 2022

Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it!

@mergify mergify bot added the pr/ready-to-merge This PR is ready to be merged. label Jan 24, 2022
@mergify
Copy link
Contributor

mergify bot commented Jan 24, 2022

Merging (with squash)...

@mergify mergify bot merged commit 5769771 into main Jan 24, 2022
@mergify mergify bot deleted the huijbers/submodule-readme branch January 24, 2022 12:54
@mergify mergify bot removed the pr/ready-to-merge This PR is ready to be merged. label Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(aws_lambda): Broken link to example
2 participants