fix(jsii): compiler allows inheriting interface-violating members #3343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The compiler failed to check inherited members from a base class against interfaces declared on the inheriting class, so that it was possible to inherit members that changed the signature of the interface declarations they implemented (typically specializing them: required implementations of optional properties, etc...). While this is valid TypeScript (the implementation is allowed to be strictly more specific than the interface declaration), this is not allowed by jsii as this results in type models that cannot be represented in C# (and other languages that do not allow specialization by implementing or overriding members). In addition to fixing this issue, this change adds source bindings to diagnostics generated when property implementations are rejected, and fixes a logical error in the message for `JSII5010` (`immutable` and `mutable` were reversed so the message read the wrong way around).
rix0rrr
approved these changes
Jan 18, 2022
|
Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it! |
|
Merging (with squash)... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The compiler failed to check inherited members from a base class against
interfaces declared on the inheriting class, so that it was possible to
inherit members that changed the signature of the interface declarations
they implemented (typically specializing them: required implementations
of optional properties, etc...).
While this is valid TypeScript (the implementation is allowed to be
strictly more specific than the interface declaration), this is not
allowed by jsii as this results in type models that cannot be
represented in C# (and other languages that do not allow specialization
by implementing or overriding members).
In addition to fixing this issue, this change adds source bindings to
diagnostics generated when property implementations are rejected, and
fixes a logical error in the message for
JSII5010(immutableandmutablewere reversed so the message read the wrong way around).Fixes #3342
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.