fix(go): unable to reuse instances between child/parent interfaces #3321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Marked as draft because this builds on top of #3316 (will mark as "ready for review" once that has shipped). |
RomainMuller
force-pushed
the
rmuller/go-reuse-iface-refs
branch
from
3f9655e
to
654ef83
Compare
RomainMuller
changed the title
The go runtime was not tracking aliases in a way that enabled it to return an alternate proxy to an object instance when that had previously been returned as a different, singular interface. This change keeps tack of the "first ever" registered instance against a given InstanceID (as this is likely the one that was natively constructed), but also to all proxy aliases to the same InstanceID, so that it can later return an existing proxy that can be converted to a desired type. Fixes #2688
RomainMuller
force-pushed
the
rmuller/go-reuse-iface-refs
branch
from
654ef83
to
8724b1b
Compare
MrArnoldPalmer
approved these changes
Jan 26, 2022
|
Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it! |
|
Merging (with squash)... |
|
Merging (with squash)... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The go runtime was not tracking aliases in a way that enabled it to
return an alternate proxy to an object instance when that had previously
been returned as a different, singular interface.
This change keeps tack of the "first ever" registered instance against a
given InstanceID (as this is likely the one that was natively
constructed), but also to all proxy aliases to the same InstanceID, so
that it can later return an existing proxy that can be converted to a
desired type.
Fixes #2688
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.