Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make a library from common files in templater that can be shared between EKS-D/A #237

Open
zafs23 opened this issue Dec 7, 2022 · 0 comments
Assignees
Labels
good first issue Good for newcomers

Comments

@zafs23
Copy link
Member

zafs23 commented Dec 7, 2022

EKS-A templater has a main.go which is almost similar to EKS-D with a few custom changes to generate EKS-A specific prow jobs. As the change is small, the plan is to make a library based on templater/jobs/utils, templater/jobs/types and templater/main.go so that this functionality can be shared in templaters across EKS-A and EKS-D to reduce duplication of code and keep templaters in sync.

Two possible approaches:

  1. Import packages into the go templater program that lives in both repos
  2. Publish a binary that is pulled in by both repos.
@zafs23 zafs23 self-assigned this Dec 7, 2022
@zafs23 zafs23 changed the title Make templater code a library that can be shared between EKS-D/A Make a library from common files in templater that can be shared between EKS-D/A Dec 8, 2022
@markapruett markapruett added the good first issue Good for newcomers label Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants