Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gem displays deprecation warning in ruby 3.3 #2984

Open
nathansamson opened this issue Feb 11, 2024 · 7 comments · Fixed by #2986
Open

Gem displays deprecation warning in ruby 3.3 #2984

nathansamson opened this issue Feb 11, 2024 · 7 comments · Fixed by #2986
Labels
breaking-change Issue requires a breaking change to remediate. dependencies This issue is a problem in a dependency.

Comments

@nathansamson
Copy link

Describe the bug

When running the gem in ruby 3.3 it displays the following warning

/home/nathansamson/.rbenv/versions/3.3.0/lib/ruby/gems/3.3.0/gems/aws-sdk-core-3.191.1/lib/aws-sdk-core/assume_role_web_identity_credentials.rb:5: warning: base64 was loaded from the standard library, but will no longer be part of the default gems since Ruby 3.4.0. Add base64 to your Gemfile or gemspec. Also contact author of aws-sdk-core-3.191.1 to add base64 into its gemspec.

Expected Behavior

It should not do this

Current Behavior

It displays a warning in ruby 3.3

Reproduction Steps

Use the gem

Possible Solution

Include base64 in the gemspec

Additional Information/Context

No response

Gem name ('aws-sdk', 'aws-sdk-resources' or service gems like 'aws-sdk-s3') and its version

aws-sdk-core:3.191.1

Environment details (Version of Ruby, OS environment)

Ruby 3.3, linux

@nathansamson nathansamson added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Feb 11, 2024
@jterapin
Copy link
Contributor

Hi! Thank you for opening the ticket. We are planning to make an update to address this (TBD when).

Copy link

This issue is now closed. Comments on closed issues are hard for our team to see.
If you need more assistance, please open a new issue that references this one.

@VitaliySerov
Copy link

For history - this change is reverted by #2987

And basically ruby-3.3 have deprecation warning again

@alextwoods alextwoods added investigating Issue is being investigated dependencies This issue is a problem in a dependency. and removed bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Feb 22, 2024
@alextwoods
Copy link
Contributor

Adding these libraries (base64 and bigdecimal) as explicit dependencies causes issues for some existing users and so, to address that we rolled that change back to remove those dependencies.

We will need a comprehensive strategy to address support in 3.4 without causing breaking changes for existing cases.

@mullermp
Copy link
Contributor

Re-opening for now.

@mullermp mullermp reopened this Feb 22, 2024
@mullermp mullermp added breaking-change Issue requires a breaking change to remediate. and removed investigating Issue is being investigated labels Feb 22, 2024
@nathansamson
Copy link
Author

Can we include conditional (based on the ruby version) dependencies in the gemspec file, or is that not supported?

@mullermp
Copy link
Contributor

I don't believe so, we investigated doing that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change Issue requires a breaking change to remediate. dependencies This issue is a problem in a dependency.
Projects
None yet
5 participants