Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected removal of aws-sdk-batch v1.5.0 from rubygems #2331

Closed
GProst opened this issue Jun 12, 2020 · 7 comments
Closed

Unexpected removal of aws-sdk-batch v1.5.0 from rubygems #2331

GProst opened this issue Jun 12, 2020 · 7 comments
Labels
guidance Question that needs advice or information. needs-triage This issue or PR still needs to be triaged.

Comments

@GProst
Copy link

GProst commented Jun 12, 2020

Our production stack almost went down today unexpectedly because aws-sdk-batch v1.5.0 was yanked: https://rubygems.org/gems/aws-sdk-batch/versions/1.5.0

Recovering it at the moment, hopefully upgrading the lib quickly to 1.32.1 won't create new issues for us...

Is there some plan where you specify when you're planning to remove some versions from public access?

Thanks

@GProst GProst added guidance Question that needs advice or information. needs-triage This issue or PR still needs to be triaged. labels Jun 12, 2020
@GProst
Copy link
Author

GProst commented Jun 12, 2020

I see 1.32.0 version was also yanked, have you been hacked?

@alextwoods
Copy link
Contributor

alextwoods commented Jun 12, 2020

I'm sorry this impacted you! We had an issue with a the release of gems on 6/10 that required us to yank versions of all of the sdk service gems that we published on 6/10 (see: #2327).

We have published corrected versions of those gems today - for aws-sdk-batch you should be able to use 1.32.1.

Apologies again for this! We do not regularly yank gems - we do so only when they contain incorrectly released and breaking changes.

Please feel to reach out or re-open if you run into issues using 1.32.1.

@aharbick
Copy link

Thanks for your quick reply. Can I ask for some clarification @alextwoods? We've had version 1.5.0 as a dependency for almost two years. I don't think you're saying that 1.5.0 was (re)published on 6/10, but then I don't understand why 1.5.0 needed to be unpublished if it hasn't changed in two years.

@mullermp
Copy link
Contributor

batch-1.5.0 was incorrectly yanked by myself in the heat of things yesterday. We were getting throttled when I tried automating removing the bad gems, so I started yanking manually and I was looking at the wrong line in my list. I am sorry about this. I really wish yesterday didn't exist. I was not able to unyank it because the API from Rubygems has been removed. I can reach out to the rubygems team and have it unyanked.

@aharbick
Copy link

Thanks for the transparency @mullermp. Updating was painless (working through several autoscaling deployment configuration issues on our side to get it out was a little... tricky) So I'll go with

I really wish yesterday didn't exist

😄

Lets hope better days are ahead!

@GProst
Copy link
Author

GProst commented Jun 12, 2020

@mullermp thanks for the explanation, don't be too hard on yourself
We don't rely on 1.5.0 now but having it unyanked probably not the worst idea since I think there is a chance some people could still rely on it

@mullermp
Copy link
Contributor

It has been restored. Again, I am deeply sorry.

https://rubygems.org/gems/aws-sdk-batch/versions/1.5.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
guidance Question that needs advice or information. needs-triage This issue or PR still needs to be triaged.
Projects
None yet
Development

No branches or pull requests

4 participants