Skip to content

fix(endpoints): fix FIPS endpoints for CloudFormation #4325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 12, 2023

Conversation

rix0rrr
Copy link
Contributor

@rix0rrr rix0rrr commented Jan 12, 2023

The SDK currently uses the following FIPS endpoint for CloudFormation in Gov regions:

cloudformation-fips.us-gov-west-1.amazonaws.com

According to the FIPS endpoint reference it should be:

cloudformation.us-gov-west-1.amazonaws.com
Checklist
  • npm run test passes
  • changelog is added, npm run add-change

Sorry, something went wrong.

The SDK currently uses the following FIPS endpoint for CloudFormation
in Gov regions:

```
cloudformation-fips.us-gov-west-1.amazonaws.com
```

According to the [FIPS endpoint reference](https://aws.amazon.com/compliance/fips/)
it should be:

```
cloudformation.us-gov-west-1.amazonaws.com
```
@rix0rrr rix0rrr requested a review from a team as a code owner January 12, 2023 14:54
@siddsriv siddsriv merged commit d157e69 into aws:master Jan 12, 2023
@rix0rrr rix0rrr deleted the huijbers/cloudformation-fips branch December 1, 2023 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants