Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export Token types from core.d.ts #4292

Merged
merged 3 commits into from Nov 29, 2022
Merged

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Nov 29, 2022

Fixes: #4291

Testing

Installed local aws-sdk from workspace

$ aws-sdk-js> npm pack

$ test> npm install ../aws-sdk-js/aws-sdk-2.1263.0.tgz

Verified that correct types are exported:

import AWS from "aws-sdk";

const token = new AWS.Token({ token: "token" });
const ssoTokenProvider = new AWS.SSOTokenProvider({ profile: "test" });
const staticTokenProvider = new AWS.StaticTokenProvider({ token: "token" });
const tokenProviderChain = new AWS.TokenProviderChain([]);
Checklist
  • .d.ts file is updated
  • changelog is added, npm run add-change

@trivikr trivikr marked this pull request as ready for review November 29, 2022 17:39
@trivikr trivikr requested a review from a team as a code owner November 29, 2022 17:39
@trivikr trivikr merged commit 221156e into aws:master Nov 29, 2022
@trivikr trivikr deleted the export-token-types branch November 29, 2022 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Property 'SSOTokenProvider' does not exist on type
3 participants