Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(region_config): remove mutation of global signatureVersion #4288

Merged
merged 2 commits into from Nov 28, 2022
Merged

fix(region_config): remove mutation of global signatureVersion #4288

merged 2 commits into from Nov 28, 2022

Conversation

kuhe
Copy link
Contributor

@kuhe kuhe commented Nov 28, 2022 •
edited

A fix for #4286

Checklist
  • npm run test passes
  • n/a .d.ts file is updated
  • changelog is added, npm run add-change
  • n/a run bundle exec rake docs:api and inspect doc/latest/index.html if documentation is changed
  • run npm run integration if integration test is changed
  • n/a non-code related change (markdown/git settings etc)

@kuhe kuhe requested a review from a team as a code owner November 28, 2022 20:11
@trivikr trivikr marked this pull request as draft November 28, 2022 20:16
@kuhe kuhe marked this pull request as ready for review November 28, 2022 20:47
@trivikr trivikr mentioned this pull request Nov 28, 2022
Open
4 tasks
@kuhe kuhe merged commit c6c5aab into aws:master Nov 28, 2022
@kuhe kuhe deleted the fix/signature-version branch November 28, 2022 20:53
This was referenced Nov 28, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

@ajredniwja ajredniwja ajredniwja approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kuhe @trivikr @ajredniwja