Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(event_listeners): check identity type in VALIDATE_CREDENTIALS #4287

Merged
merged 1 commit into from Nov 28, 2022

Conversation

kuhe
Copy link
Contributor

@kuhe kuhe commented Nov 28, 2022

If the identity type is bearer, the validate_credentials listener will only check the token used in bearer auth.

Internal V776401135

Checklist
  • npm run test passes
  • n/a .d.ts file is updated
  • changelog is added, npm run add-change
  • n/a run bundle exec rake docs:api and inspect doc/latest/index.html if documentation is changed
  • run npm run integration if integration test is changed
  • n/a non-code related change (markdown/git settings etc)

@kuhe kuhe requested a review from a team as a code owner November 28, 2022 18:03
@trivikr trivikr marked this pull request as draft November 28, 2022 20:18
@trivikr
Copy link
Member

trivikr commented Nov 28, 2022

Verified that integration tests are successful:

$ AWS_REGION=us-east-1 AWS_PROFILE=team node node_modules/cucumber/bin/cucumber.js
...
189 scenarios (189 passed)
720 steps (720 passed)

@trivikr trivikr marked this pull request as ready for review November 28, 2022 20:32
@trivikr trivikr merged commit b168eaa into aws:master Nov 28, 2022
@kuhe kuhe deleted the fix/validate_credentials branch March 3, 2023 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants