Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable CORS for marketplacecatalog #4229

Merged
merged 3 commits into from
Oct 12, 2022
Merged

Enable CORS for marketplacecatalog #4229

merged 3 commits into from
Oct 12, 2022

Conversation

kiranvuyyuru
Copy link
Contributor

@kiranvuyyuru kiranvuyyuru commented Oct 11, 2022 •
edited

Checklist
  • non-code related change (markdown/git settings etc)

@kiranvuyyuru kiranvuyyuru requested a review from a team as a code owner October 11, 2022 17:14
trivikr
trivikr requested changes Oct 11, 2022
View reviewed changes
Copy link
Member

@trivikr trivikr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add "cors": true in

aws-sdk-js/apis/metadata.json

Lines 791 to 794 in bb172cb

"marketplacecatalog": {
"prefix": "marketplace-catalog",
"name": "MarketplaceCatalog"
},
, and a release note.

You can refer PR #3779

@trivikr trivikr changed the title Added AWSMP Catalog API CORS availability Enable CORS for marketplacecatalog Oct 11, 2022
@kiranvuyyuru
Copy link
Contributor Author

Added the "cors": true in the metadata.json file.

trivikr
trivikr requested changes Oct 11, 2022
View reviewed changes
Copy link
Member

@trivikr trivikr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a changelog by running npm run add-change as requested by pull request template.

You can refer example changelog in #3779

@trivikr trivikr merged commit 123068e into aws:master Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kiranvuyyuru @trivikr