AWSQuery compatible error code #4221
Merged
+35
−54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When awsQueryCompatible trait is found, it's made available as an API property. When this property is found, the error code is returned by looking up the mapping. This is a pre-requisite for migrating services from AWSQuery wire protocol to AWSJson.
* Add awsQueryCompatible trait support to service When awsQueryCompatible trait is found, it's made available as an API property. When this property is found, the error code is returned by looking up the mapping. This is a pre-requisite for migrating services from AWSQuery wire protocol to AWSJson. * Minor edit * Add additional tests; review comments * Minor edits
Co-authored-by: AllanZhengYP <zheallan@amazon.com>
This reverts commit 2a87ec1.
When header value is found, then error code is populated from the header If there is no header found, then the default error code is returned.
kuhe
approved these changes
Sep 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm run testpassesnpm run add-change