Throw runtime error when unsupported features are invoked #4067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuhe
reviewed
Apr 12, 2022
lib/services/s3util.js
Outdated
| @@ -144,9 +144,14 @@ var s3util = { | |||
| var allowFipsEndpoint = options.allowFipsEndpoint || false; | |||
|
|
|||
| if (!regionFromArn) { | |||
| var message = 'ARN region is empty'; | |||
| if (req._parsedArn.service === 's3') { | |||
| message = message + '\nYou may want to use multi-regional ARN. The feature is not support in current SDK. ' + | |||
There was a problem hiding this comment.
should say not supported like in the other message.
kuhe
approved these changes
Apr 12, 2022
AllanZhengYP
force-pushed
the
throw-error-feature
branch
from
7b3baec
to
a2cef6f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both S3 mult-regional access point and the EventBridge global endpoint are not supported in V2 SDK but only implemented in V3. This change detect these invocations and throws runtime errors.
Checklist
npm run testpassesnpm run add-change