fix S3 client no longer honor the computeChecksums config #4052
+33
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AllanZhengYP
force-pushed
the
fix-s3-compute-checksum
branch
from
ed25bc3 to
afe4338
Compare
trivikr
approved these changes
Mar 11, 2022
AllanZhengYP
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up: #3799
Fixed a bug that S3 client no longer honor the computeChecksums config introduced in #3799. Previously only the members with
httpChecksumRequiredtrait will be disabled by unsetingcomputeChecksumsconfig. S3 doesn't not honor the config because it has its own logic handling MD5 chechsums.Checklist
npm run testpassesnpm run add-change