Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add useFipsEndpoint configuration #3951

Merged
merged 24 commits into from Nov 11, 2021
Merged

Add useFipsEndpoint configuration #3951

merged 24 commits into from Nov 11, 2021

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Nov 10, 2021 •
edited

This PR:

  • Adds useFipsEndpoint configuration.
  • Adds tests for useFipsEndpoint configuration.
  • Sets real region in region, and sets useFipsEndpoint to true if it was pseudo region.
  • Replaces all checks for isFipsRegion across the SDK with useFipsEndpoint.
  • Removes checks for signingRegion from legacy fips endpoint tests.
  • Reads useFipsEndpoint from environment or shared ini configuration.
Checklist
  • npm run test passes
  • changelog is added, npm run add-change
  • run npm run integration if integration test is changed

@trivikr trivikr mentioned this pull request Nov 10, 2021
Closed
5 tasks
@trivikr trivikr changed the base branch from fips-region-config to master November 10, 2021 22:38
@trivikr
test(endpoint): remove test cases for useFipsEndpoint
dcaffb9 
This reverts commit 44144ba.
Tests to be added later.
@trivikr
chore: switch to useFipsRegion instead of isFipsRegion
c9507b6
@trivikr
feat: store real region in region_config
e8fc0a2
@trivikr
test(endpoint): remove checks for signingRegion
42c08b9
@trivikr
test(endpoint): add test cases for useFipsEndpoint
492a4bf
@trivikr
chore: set real region for global regions
5b12c22
@trivikr
chore(region_config): add support for us-iso-* and us-isob-*
6c267fd
@trivikr
chore(region_config): add support for iam under fips
c919355
@trivikr
chore: npm run add-change
407d2fe
@trivikr
fix(service): check for config before checking for region
0fe42a8
@trivikr
chore: update region-checker allowlist
e8cd520
@trivikr
test(region_config): remove fips signingRegion tests
7d2be4b
@trivikr
chore(s3): check useFipsEndpoint for fips compatibility
c665393
@trivikr
test(s3): add all combinations of fips testing
f25bcd2
@trivikr
test(service): set original signingName and endpointPrefix after testing
87b8a25 
These tests were somehow failing endpoint tests.
@trivikr
test(region_utils): add tests for region utils
62b8bc2
@trivikr
test(service): useFipsEndpoint for fips region and global region
7373695
@trivikr
chore(node_loader): set real region and useFipsEndpoint
259e486
@trivikr
test(service): delete AWS.config.s3 before exiting test
0715654
@trivikr trivikr marked this pull request as ready for review November 11, 2021 17:51
@trivikr trivikr requested a review from a team as a code owner November 11, 2021 17:51
@trivikr trivikr changed the title [WIP] Add useFipsEndpoint configuration Add useFipsEndpoint configuration Nov 11, 2021
@trivikr trivikr marked this pull request as draft November 11, 2021 18:00
@trivikr trivikr marked this pull request as ready for review November 11, 2021 18:19
@trivikr trivikr merged commit d0620c4 into aws:master Nov 11, 2021
@trivikr trivikr deleted the useFipsEndpoint-dev branch November 11, 2021 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AllanZhengYP AllanZhengYP AllanZhengYP approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@trivikr @AllanZhengYP