Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update clock skew from 30s to 300s #2954

Merged
merged 1 commit into from
Nov 15, 2019
Merged

chore: update clock skew from 30s to 300s #2954

merged 1 commit into from
Nov 15, 2019

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Nov 13, 2019

Fixes: #2953

Checklist
  • npm run test passes
  • changelog is added, npm run add-change

Sorry, something went wrong.

@codecov-io
Copy link

codecov-io commented Nov 13, 2019

Codecov Report

Merging #2954 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2954   +/-   ##
=======================================
  Coverage   96.99%   96.99%           
=======================================
  Files         307      307           
  Lines        9076     9076           
  Branches     1677     1677           
=======================================
  Hits         8803     8803           
  Misses        273      273
Impacted Files Coverage Δ
lib/service.js 98.14% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6bd3a5...02e5867. Read the comment docs.

Copy link
Contributor

@ajredniwja ajredniwja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!!

@trivikr trivikr merged commit 212e2e3 into aws:master Nov 15, 2019
@trivikr trivikr deleted the correct-clock-skew branch November 15, 2019 01:42
@lock
Copy link

lock bot commented Nov 22, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators Nov 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

clockSkew for services is 30s instead of 300s
3 participants