Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(lib-storage): add available checksum values to CompletedPart array #3350

Merged
merged 1 commit into from Feb 24, 2022

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Feb 23, 2022

Issue

Internal JS-3100

Description

Adds available checksum values to CompletedPart array

Testing

Tested with model updates in https://github.com/aws/private-aws-sdk-js-v3/pull/106


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr requested a review from a team as a code owner February 23, 2022 01:38
Copy link
Contributor

@AllanZhengYP AllanZhengYP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@trivikr
Copy link
Member Author

trivikr commented Feb 23, 2022

This PR will be rebased and merged after the models are updated for client-s3. Moving to draft.

@trivikr trivikr marked this pull request as draft February 23, 2022 17:43
@trivikr trivikr force-pushed the lib-storage-flexible-checksums branch from 849b361 to 9c2d945 Compare February 24, 2022 20:03
@trivikr trivikr marked this pull request as ready for review February 24, 2022 20:03
@trivikr trivikr merged commit 8d9bfba into aws:main Feb 24, 2022
@trivikr trivikr deleted the lib-storage-flexible-checksums branch February 24, 2022 20:26
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants