Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(util-stream): add getAwsChunkedEncodingStream #3339

Merged
merged 8 commits into from Feb 22, 2022

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Feb 20, 2022

Issue

Internal JS-2965

Description

Adds getAwsChunkedEncodingStream functions in browser and Node.js

Testing

Integration testing done in https://github.com/aws/private-aws-sdk-js-v3/pull/75
Unit tests will be added in a separate PR.


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr requested a review from a team as a code owner February 20, 2022 18:43
Copy link
Contributor

@AllanZhengYP AllanZhengYP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just one very nit.

packages/util-stream-browser/README.md Outdated Show resolved Hide resolved
Co-authored-by: AllanZhengYP <zheallan@amazon.com>
@trivikr trivikr merged commit 42d433b into aws:main Feb 22, 2022
@trivikr trivikr deleted the add-util-stream branch February 22, 2022 03:49
@github-actions
Copy link

github-actions bot commented Mar 9, 2022

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants