feat(hash-stream-node): add readableStreamHasher #3088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #3088 +/- ##
==========================================
+ Coverage 58.72% 58.74% +0.01%
==========================================
Files 571 572 +1
Lines 30620 30632 +12
Branches 7541 7541
==========================================
+ Hits 17982 17994 +12
Misses 12638 12638
Continue to review full report at Codecov.
|
The pipe will get created before await/then is called on Promise. This way hashCalculator will consume Readable Stream if it starts flowing before await is called.
The pipes array was added in v13.0.0 nodejs/node#28583
AllanZhengYP
approved these changes
Dec 10, 2021
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Internal JS-2965
Description
Adds readableStreamHasher which pipes the provided stream to hashConstructor
Testing
Unit tests
Additional Context
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.