Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ECS Client has missing SettingName for the dualStackIPv6 option #5885

Open
3 tasks done
jmenga-aset opened this issue Mar 13, 2024 · 3 comments
Open
3 tasks done

ECS Client has missing SettingName for the dualStackIPv6 option #5885

jmenga-aset opened this issue Mar 13, 2024 · 3 comments
Assignees
Labels
bug This issue is a bug. p2 This is a standard priority issue service-api This issue is due to a problem in a service API, not the SDK implementation.

Comments

@jmenga-aset
Copy link

jmenga-aset commented Mar 13, 2024

Checkboxes for prior research

Describe the bug

The ECS Client SettingName enum is missing an option for the dualStackIPv6 option (as indicated here)

SDK version number

@aws-sdk/client-ecs@3.529.1

Which JavaScript Runtime is this issue in?

Node.js

Details of the browser/Node.js/ReactNative version

v20.10.0

Reproduction Steps

import { SettingName } from '@aws-sdk/client-ecs'

console.log(SettingName)

Observed Behavior

The following output is generated:

{
  AWSVPC_TRUNKING: 'awsvpcTrunking',
  CONTAINER_INSIGHTS: 'containerInsights',
  CONTAINER_INSTANCE_LONG_ARN_FORMAT: 'containerInstanceLongArnFormat',
  FARGATE_FIPS_MODE: 'fargateFIPSMode',
  FARGATE_TASK_RETIREMENT_WAIT_PERIOD: 'fargateTaskRetirementWaitPeriod',
  GUARD_DUTY_ACTIVATE: 'guardDutyActivate',
  SERVICE_LONG_ARN_FORMAT: 'serviceLongArnFormat',
  TAG_RESOURCE_AUTHORIZATION: 'tagResourceAuthorization',
  TASK_LONG_ARN_FORMAT: 'taskLongArnFormat'
}

Expected Behavior

There should be a key/value pair for the value dualStackIPv6

e.g.

{
  DUAL_STACK_IPV6: 'dualStackIPv6'
}

Possible Solution

Update the SettingName object to the following:

export const SettingName = {
  AWSVPC_TRUNKING: "awsvpcTrunking",
  CONTAINER_INSIGHTS: "containerInsights",
  CONTAINER_INSTANCE_LONG_ARN_FORMAT: "containerInstanceLongArnFormat",
  DUAL_STACK_IPV6: 'dualStackIPv6'
  FARGATE_FIPS_MODE: "fargateFIPSMode",
  FARGATE_TASK_RETIREMENT_WAIT_PERIOD: "fargateTaskRetirementWaitPeriod",
  GUARD_DUTY_ACTIVATE: "guardDutyActivate",
  SERVICE_LONG_ARN_FORMAT: "serviceLongArnFormat",
  TAG_RESOURCE_AUTHORIZATION: "tagResourceAuthorization",
  TASK_LONG_ARN_FORMAT: "taskLongArnFormat",
} as const;

Additional Information/Context

No response

@jmenga-aset jmenga-aset added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Mar 13, 2024
@RanVaknin
Copy link
Contributor

Hi @jmenga-aset ,

Thanks for reaching out. Its not clear if this was never modeled, or was removed. I'm curious, if you had to supply the string value directly instead of using the enum, does dualStackIPv6 actually work?

The reason why I'm asking is sometimes service teams remove enum values (in favor of introducing new parameters or deprecating old ones) and forget to remove the corresponding documentation.

Thanks,
Ran~

@RanVaknin RanVaknin self-assigned this Mar 15, 2024
@RanVaknin RanVaknin added response-requested Waiting on additional info and feedback. Will move to \"closing-soon\" in 7 days. p2 This is a standard priority issue service-api This issue is due to a problem in a service API, not the SDK implementation. and removed needs-triage This issue or PR still needs to be triaged. labels Mar 15, 2024
Copy link

This issue has not received a response in 1 week. If you still think there is a problem, please leave a comment to avoid the issue from automatically closing.

@github-actions github-actions bot added the closing-soon This issue will automatically close in 4 days unless further comments are made. label Mar 26, 2024
@mixja
Copy link

mixja commented Mar 26, 2024

Yes dualStackIPv6 is a documented setting and works - see docs

@github-actions github-actions bot removed closing-soon This issue will automatically close in 4 days unless further comments are made. response-requested Waiting on additional info and feedback. Will move to \"closing-soon\" in 7 days. labels Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. p2 This is a standard priority issue service-api This issue is due to a problem in a service API, not the SDK implementation.
Projects
None yet
Development

No branches or pull requests

3 participants