Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(clients): populate message field when parsing errors #3995

Merged
merged 2 commits into from Sep 28, 2022

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Sep 28, 2022

Issue

Refs: smithy-lang/smithy-typescript#597

Description

Populates message field when parsing errors. This is required, as service response may populate error message in Message even though it's modeled to be in message.

Testing

  • CI is successful.
  • Integration tests are successful.
  • Detailed testing will be done by ensuring elasticache error test does not fail after AWSQueryError trait is reintroduced (repeat of feat: Support awsQueryError trait #3174 which was reverted in chore: revert support for awsQueryError trait #3193):
    1) Scenario: Error handling # features/elasticache/elasticache.feature:15
      ✔ Before # features/elasticache/step_definitions/elasticache.js:3
      ✔ Before # features/extra/hooks.js:15
      ✔ Given I create a cache parameter group with name prefix "" # features/elasticache/step_definitions/elasticache.js:9
      ✔ Then the error code should be "InvalidParameterValue" # features/extra/hooks.js:93
      ✖ Then the error message should contain: # features/extra/hooks.js:99
          """
          The parameter CacheParameterGroupName must be provided and must not be blank
          """
          AssertionError [ERR_ASSERTION]: Expected InvalidParameterValue to match The parameter CacheParameterGroupName must be provided and must not be blank
              at Function.assertMatches [as match] (/codebuild/output/src969879309/src/root/release-artifacts/aws-sdk-js-v3/features/extra/assertions.js:4:10)
              at Object.<anonymous> (/codebuild/output/src969879309/src/root/release-artifacts/aws-sdk-js-v3/features/extra/hooks.js:103:23)
    

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr marked this pull request as ready for review September 28, 2022 21:42
@trivikr trivikr requested a review from a team as a code owner September 28, 2022 21:42
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants