Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a separate WARN log for SDK credentials refresh failure #2351

Closed
azlwwan opened this issue Jun 4, 2020 · 2 comments
Closed

Add a separate WARN log for SDK credentials refresh failure #2351

azlwwan opened this issue Jun 4, 2020 · 2 comments
Labels
feature-request A feature should be added or improved.

Comments

@azlwwan
Copy link

azlwwan commented Jun 4, 2020

The debug log level at here hides the error of fetch credentials failure. This blocks customers from monitoring this hidden failure which could result with system wide failure.

Describe the Feature

By adding a new WARN level log statement, customers can use MetricsFilter and Alarms in CloudWatch to detect this hidden failure to prevent the approaching system wide failure by replacing the alarming EC2 instances asap.

Is your Feature Request related to a problem?

Yes, when the credentials in BaseCredentialsFetcher expired after 60 mins, application logs in EC2 instance probably not be able to publish to CloudWatch, because awslog publish also uses the same credentials from EC2 instance role. This means there is no way for customers to monitor and defect this failure in CloudWatch in early manner.

Proposed Solution

By adding a new WARN level log statement similar like this, but using an explicit string, customer can use MetricsFilter and Alarms in CloudWatch to detect this hidden failure 15 mins before the credential expires. This 15 mins should be enough for customers to take action and replace the stale instances, but it will be better to have 30 mins.

Describe alternatives you've considered

Additional Context

Your Environment

  • AWS Java SDK version used: 1.11
  • JDK version used: OpenJDK 1.8.0_192
  • Operating System and version: AL2012
@azlwwan azlwwan added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Jun 4, 2020
@debora-ito
Copy link
Member

It's a reasonable ask @azlwwan, marking as a feature request.

@debora-ito debora-ito removed the needs-triage This issue or PR still needs to be triaged. label Jun 8, 2020
@debora-ito
Copy link
Member

The log level in BaseCredentialsFetcher#handleError() was changed to WARN in SDK version 1.11.799.

Closing this, feel free to reopen if you have further questions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A feature should be added or improved.
Projects
None yet
Development

No branches or pull requests

2 participants