Fix javadoc to make it build with JDK 17 #3415
Conversation
pom.xml
Outdated
| <executions> | ||
| <execution> | ||
| <id>generate-javadocs</id> | ||
| <phase>package</phase> | ||
| <goals> | ||
| <goal>javadoc</goal> | ||
| </goals> | ||
| <configuration> | ||
| <detectJavaApiLink>false</detectJavaApiLink> | ||
| <source>8</source> | ||
| <notree>true</notree> | ||
| <includeDependencySources>false</includeDependencySources> | ||
| <doclint>none</doclint> | ||
| </configuration> | ||
| </execution> | ||
| </executions> | ||
| </plugin> |
There was a problem hiding this comment.
This will likely increase our build time because we are generating Javadocs now as part of the build.
There was a problem hiding this comment.
Build took at least 15 mins longer after the change. We probably should not build it then or at least disable it for service modules
There was a problem hiding this comment.
- Are we going to use these Java Docs in https://github.com/aws/aws-sdk-java-v2/blob/master/buildspecs/release-javadoc.yml ?
- Why didn't we consider adding it as parallel step , since we have failures due to intermittent test failures.
There was a problem hiding this comment.
Nope, they are part of the build process. I tested it and it did not increase the build time w/ service modules disabled.
I considered creating another codebuild job to run the same command as release-javadoc, but the whole job can take more than one hour and it works with the largest instance, so I went with this approach.
zoewangg
changed the title
|
Kudos, SonarCloud Quality Gate passed! |
Motivation and Context
Fix javadoc so that we can use JDK 17 to generate Javadoc site
Modifications
Testing
Tested locally with JDK17 as well as CodeBuild job