Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip Signing of requests which are defined with authtype as none #3281

Merged
merged 1 commit into from Jul 8, 2022

Conversation

joviegas
Copy link
Contributor

@joviegas joviegas commented Jul 7, 2022

Motivation and Context

    "SignUp":{
      "name":"SignUp",
      "http":{
        "method":"POST",
        "requestUri":"/"
      },
      "input":{"shape":"SignUpRequest"},
      "output":{"shape":"SignUpResponse"},
      "errors":[
        {"shape":"ResourceNotFoundException"},
      ],
      "authtype":"none"
    },

Operations as above explicitly mentions that the authtype should be none. In such cases the requests should not be authorized and credentials should not be resolved for such requests.

Modifications

  • Added a new executionAttribute to mark the operations which are authtype as none.
  • This executionAttribute is then used while assigning signers and credentials.
  • Note that signer is assigned as Null because if we assign a Dumy or NoOp signer its still a signer and should be considered in merics collection, thus to avoid unecessary metrics collection its best to allocate signer as null.
  • Credentials as assigned to Annonymous credentials if Auth type is none.

Testing

  • Added Junits
  • Tested cognitoidentityprovider service which had AuthType as none.

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@joviegas joviegas requested a review from a team as a code owner July 7, 2022 13:48
@sonarcloud
Copy link

sonarcloud bot commented Jul 7, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

97.0% 97.0% Coverage
0.0% 0.0% Duplication

@joviegas joviegas merged commit 1d92f36 into master Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants