Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding cloudwatch-metric-publisher to bom #2308

Merged
merged 3 commits into from Mar 2, 2021

Conversation

debora-ito
Copy link
Member

Description

Adding client side metrics cloudwatch-metric-publisher to bom

Motivation and Context

Testing

Run mvn install

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have read the README document
  • I have added tests to cover my changes
  • All new and existing tests passed
  • A short description of the change has been added to the CHANGELOG
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@codecov-io
Copy link

Codecov Report

Merging #2308 (e2609e9) into master (16b1f57) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2308      +/-   ##
============================================
+ Coverage     77.64%   77.65%   +0.01%     
  Complexity      366      366              
============================================
  Files          1239     1239              
  Lines         39033    39033              
  Branches       3081     3081              
============================================
+ Hits          30306    30311       +5     
+ Misses         7257     7253       -4     
+ Partials       1470     1469       -1     
Flag Coverage Δ Complexity Δ
unittests 77.65% <ø> (+0.01%) 0.00 <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...ssdk/core/internal/async/FileAsyncRequestBody.java 84.90% <0.00%> (+1.88%) 0.00% <0.00%> (ø%)
...nio/netty/internal/OldConnectionReaperHandler.java 90.90% <0.00%> (+9.09%) 0.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16b1f57...e9ce289. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented Mar 2, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@debora-ito debora-ito merged commit a186ae5 into aws:master Mar 2, 2021
aws-sdk-java-automation added a commit that referenced this pull request Dec 29, 2022
…b784be2bf

Pull request: release <- staging/6970c3d2-e8f7-4eba-a824-52eb784be2bf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants