Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid example date on HeadObjectResponse.restore() #2302

Closed
pwinckles opened this issue Feb 26, 2021 · 3 comments
Closed

Invalid example date on HeadObjectResponse.restore() #2302

pwinckles opened this issue Feb 26, 2021 · 3 comments
Labels
documentation This is a problem with documentation. service-api This issue is due to a problem in a service API, not the SDK implementation.

Comments

@pwinckles
Copy link

Describe the issue

There's an invalid date in the documentation for HeadObjectResponse.restore():

If the object is an archived object (an object whose storage class is GLACIER), the response includes this header if either the archive restoration is in progress (see RestoreObject or an archive copy is already restored.

If an archive copy is already restored, the header value indicates when Amazon S3 is scheduled to delete the object copy. For example:

x-amz-restore: ongoing-request="false", expiry-date="Fri, 23 Dec 2012 00:00:00 GMT"

If the object restoration is in progress, the header returns the value ongoing-request="true".

For more information about archiving objects, see Transitioning Objects: General Considerations.

December 23, 2012 was a Sunday.

Fri, 23 Dec 2012 00:00:00 GMT should either be Sun, 23 Dec 2012 00:00:00 GMT or Fri, 21 Dec 2012 00:00:00 GMT

Links

https://github.com/aws/aws-sdk-java-v2/blob/master/services/s3/src/main/resources/codegen-resources/service-2.json#L4606

@pwinckles pwinckles added documentation This is a problem with documentation. needs-triage This issue or PR still needs to be triaged. labels Feb 26, 2021
@debora-ito
Copy link
Member

Thank you for reporting this @pwinckles, I will forward to the S3 documentation team.

@debora-ito debora-ito added service-api This issue is due to a problem in a service API, not the SDK implementation. and removed needs-triage This issue or PR still needs to be triaged. labels Mar 1, 2021
@debora-ito
Copy link
Member

@pwinckles the docs are now fixed, they read Fri, 21 Dec 2012 00:00:00 GMT. Thank you again.

@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

aws-sdk-java-automation added a commit that referenced this issue Dec 22, 2022
…b11c4e105

Pull request: release <- staging/f2449b29-a2d2-4253-87c4-d28b11c4e105
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation This is a problem with documentation. service-api This issue is due to a problem in a service API, not the SDK implementation.
Projects
None yet
Development

No branches or pull requests

2 participants