Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing module-path tests failure #2299

Merged
merged 1 commit into from Feb 24, 2021
Merged

Fixing module-path tests failure #2299

merged 1 commit into from Feb 24, 2021

Conversation

joviegas
Copy link
Contributor

@joviegas joviegas commented Feb 24, 2021

Description

Fixing module-path tests failure.

Motivation and Context

#2270 reported failure in module path

module software.amazon.awssdk.protocols.json reads package software.amazon.awssdk.protocols.json.internal from both software.amazon.awssdk.protocols.json and software.amazon.awssdk.protocols.core

Root cause

Testing

  • Tested below
mvn clean package
mvn exec:exec -P mock-tests
mvn exec:exec -P integ-tests

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have read the README document
  • I have added tests to cover my changes
  • All new and existing tests passed
  • A short description of the change has been added to the CHANGELOG
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@codecov-io
Copy link

codecov-io commented Feb 24, 2021

Codecov Report

Merging #2299 (1a49b4d) into master (41a8600) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2299   +/-   ##
=========================================
  Coverage     77.63%   77.63%           
  Complexity      366      366           
=========================================
  Files          1239     1239           
  Lines         39033    39033           
  Branches       3081     3081           
=========================================
+ Hits          30302    30304    +2     
+ Misses         7259     7258    -1     
+ Partials       1472     1471    -1     
Flag Coverage Δ Complexity Δ
unittests 77.63% <ø> (+<0.01%) 0.00 <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...awssdk/protocols/json/internal/MarshallerUtil.java 100.00% <ø> (ø) 0.00 <0.00> (?)
...ty/internal/IdleConnectionCountingChannelPool.java 87.80% <0.00%> (+1.21%) 0.00% <0.00%> (ø%)
...zon/awssdk/core/internal/capacity/TokenBucket.java 70.73% <0.00%> (+2.43%) 0.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41a8600...1a49b4d. Read the comment docs.

Copy link
Contributor

@zoewangg zoewangg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a changelog entry?

@joviegas
Copy link
Contributor Author

Can we add a changelog entry?
Done.

@sonarcloud
Copy link

sonarcloud bot commented Feb 24, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@joviegas joviegas merged commit bac977a into aws:master Feb 24, 2021
aws-sdk-java-automation pushed a commit that referenced this pull request Dec 20, 2022
Add transfer manager to bom
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants