Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix archetype-lambda #2085

Merged
merged 2 commits into from Oct 13, 2020
Merged

Fix archetype-lambda #2085

merged 2 commits into from Oct 13, 2020

Conversation

zoewangg
Copy link
Contributor

Description

Fixed an issue where archetype generation failed with latest maven-archetype-plugin by
copying the global.vm to archetype resources folder because it's no longer global any more ¯_(ツ)_/¯

I tried other ways such as using relative path and none of them worked.

Motivation and Context

#1981

Testing

Unit tests passed.
Tried using both new version of old version of archetype plugin to generate a new project and both worked.

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have read the README document
  • I have added tests to cover my changes
  • All new and existing tests passed
  • A short description of the change has been added to the CHANGELOG
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@zoewangg zoewangg merged commit 952e9f0 into master Oct 13, 2020
@zoewangg zoewangg deleted the zoewang/fixArchetype branch October 13, 2020 18:10
@sonarcloud
Copy link

sonarcloud bot commented Oct 13, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

warning The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more here

aws-sdk-java-automation added a commit that referenced this pull request Jul 7, 2022
…601e6b418

Pull request: release <- staging/16bc1dbf-8e83-4bd0-a839-a4e601e6b418
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants