Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed an issue where CloudWatchMetricPublisher might not always complete flushing pending metrics on close. #1984

Merged
merged 1 commit into from Aug 12, 2020

Conversation

millems
Copy link
Contributor

@millems millems commented Aug 11, 2020

No description provided.

…plete flushing pending metrics on `close`.
@millems millems force-pushed the millem/async-close-more-better branch from 6654712 to 901a51f Compare August 12, 2020 18:04
@sonarcloud
Copy link

sonarcloud bot commented Aug 12, 2020

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 2 Code Smells

60.6% 60.6% Coverage
0.0% 0.0% Duplication

warning The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more here

@codecov-commenter
Copy link

codecov-commenter commented Aug 12, 2020

Codecov Report

Merging #1984 into master will decrease coverage by 0.01%.
The diff coverage is 61.76%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1984      +/-   ##
============================================
- Coverage     76.67%   76.66%   -0.02%     
  Complexity      225      225              
============================================
  Files          1112     1112              
  Lines         33656    33667      +11     
  Branches       2621     2619       -2     
============================================
+ Hits          25807    25812       +5     
- Misses         6572     6579       +7     
+ Partials       1277     1276       -1     
Flag Coverage Δ Complexity Δ
#unittests 76.66% <61.76%> (-0.02%) 225.00 <0.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...blishers/cloudwatch/CloudWatchMetricPublisher.java 77.41% <57.69%> (+0.31%) 0.00 <0.00> (ø)
...s/cloudwatch/internal/task/UploadMetricsTasks.java 84.61% <75.00%> (-15.39%) 0.00 <0.00> (ø)
.../http/nio/netty/internal/NettyRequestExecutor.java 72.09% <0.00%> (-5.12%) 0.00% <0.00%> (ø%)
...http/nio/netty/internal/nrs/HandlerSubscriber.java 79.31% <0.00%> (-3.45%) 0.00% <0.00%> (ø%)
...ssdk/core/internal/async/FileAsyncRequestBody.java 87.61% <0.00%> (+2.85%) 0.00% <0.00%> (ø%)
...ttp/nio/netty/internal/nrs/HttpStreamsHandler.java 64.61% <0.00%> (+3.84%) 0.00% <0.00%> (ø%)
...ine/stages/ApiCallAttemptTimeoutTrackingStage.java 100.00% <0.00%> (+6.89%) 0.00% <0.00%> (ø%)
...nio/netty/internal/OldConnectionReaperHandler.java 90.90% <0.00%> (+9.09%) 0.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09c7d03...901a51f. Read the comment docs.

@millems millems merged commit f9fba79 into master Aug 12, 2020
@millems millems deleted the millem/async-close-more-better branch August 12, 2020 19:11
aws-sdk-java-automation pushed a commit that referenced this pull request Apr 7, 2022
…0e5498e96

Pull request: release <- staging/9370d83f-3e00-4034-a4bb-4b20e5498e96
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants