Skip to content

Improved exception messages in credential providers… #1273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 29, 2019

Conversation

millems
Copy link
Contributor

@millems millems commented May 29, 2019

…to exclude detailed parse errors that may contain sensitive information.

…ed parse errors that may contain sensitive information.
@millems millems force-pushed the millem/improve-exception-messages branch from 0a22e60 to 9ba9582 Compare May 29, 2019 22:35
@millems millems merged commit 0afe7c9 into master May 29, 2019
@millems millems deleted the millem/improve-exception-messages branch May 29, 2019 22:48
@codecov-io
Copy link

Codecov Report

Merging #1273 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1273      +/-   ##
============================================
+ Coverage     70.15%   70.16%   +<.01%     
  Complexity      188      188              
============================================
  Files           776      776              
  Lines         24129    24129              
  Branches       1799     1799              
============================================
+ Hits          16927    16929       +2     
+ Misses         6420     6416       -4     
- Partials        782      784       +2
Flag Coverage Δ Complexity Δ
#unittests 70.16% <100%> (ø) 188 <0> (ø) ⬇️
Impacted Files Coverage Δ Complexity Δ
...ssdk/auth/credentials/HttpCredentialsProvider.java 58.33% <100%> (ø) 0 <0> (ø) ⬇️
...o/netty/internal/http2/HttpOrHttp2ChannelPool.java 78.49% <0%> (-1.08%) 0% <0%> (ø)
...are/amazon/awssdk/core/util/json/JacksonUtils.java 55.55% <0%> (+11.11%) 0% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 101d78d...9ba9582. Read the comment docs.

aws-sdk-java-automation added a commit that referenced this pull request Apr 14, 2021

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
…e6adfda29

Pull request: release <- staging/dccf4bda-05b8-470d-9e9e-c92e6adfda29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants